Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit-Tests for Model.py #112

Merged
merged 19 commits into from Apr 24, 2023
Merged

Unit-Tests for Model.py #112

merged 19 commits into from Apr 24, 2023

Conversation

manuGil
Copy link
Collaborator

@manuGil manuGil commented Apr 5, 2023

  • Unit tests for the StreamFormatter
  • Unit test for the ModelState class
  • Type hints, docstrings and comments to the code in model.py

@manuGil manuGil added the test label Apr 9, 2023
niketagrawal
niketagrawal approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@niketagrawal niketagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the tests, type hints and docstrings.

aeolis/model.py Outdated
scale=2.):
mean_speed:float=9.0,
max_speed:float=30.0,
dt:float=60., # what is the meaning of dt?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dt is timestep; correct @Sierd ?

@manuGil manuGil merged commit c307302 into main Apr 24, 2023
3 checks passed
@manuGil manuGil deleted the feature/code-review branch April 24, 2023 09:09
@niketagrawal niketagrawal mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niketagrawal niketagrawal niketagrawal approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuGil @niketagrawal