Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loop over fractions replaced by numba enhanced function #119

Merged
merged 1 commit into from Jul 5, 2023
Merged

loop over fractions replaced by numba enhanced function #119

merged 1 commit into from Jul 5, 2023

Conversation

Sierd
Copy link
Collaborator

@Sierd Sierd commented May 15, 2023

fixes #118

@Sierd
Copy link
Collaborator Author

Sierd commented May 15, 2023

Niket this seems to work but in only provides some marginal optimization.
Could you run the profiler over this code again?

@Sierd
Copy link
Collaborator Author

Sierd commented May 16, 2023

Some benchmarking using the profiler has shown that the code works but the performance does not increase. Well, at least the code is not slower :).

@manuGil manuGil added this to the Handing over milestone Jun 28, 2023
@niketagrawal niketagrawal merged commit 958fb0f into main Jul 5, 2023
3 checks passed
@niketagrawal niketagrawal deleted the bed.py-speedup branch October 11, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niketagrawal niketagrawal niketagrawal approved these changes

@bartvanwesten bartvanwesten Awaiting requested review from bartvanwesten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Handing over
Development

Successfully merging this pull request may close these issues.

Propagation of grains sizes through vertical layers slows down code
3 participants
@Sierd @niketagrawal @manuGil