Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing TOML file for packaging #125

Merged
merged 22 commits into from Jun 28, 2023
Merged

Implementing TOML file for packaging #125

merged 22 commits into from Jun 28, 2023

Conversation

manuGil
Copy link
Collaborator

@manuGil manuGil commented Jun 21, 2023

  • Implement pyproject.toml
  • Change build-system from setuptools to hatchling
  • Remove docs/ and test/ directories from source disbtirution
  • Update Readme.md Release.md and Contiguting.md
  • Modified model.py for fetching version from package metadata

Closes #107
Fixes #36

Copy link
Collaborator

@niketagrawal niketagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changes.

The publish-workflow.yml needs to be modified because the names of the source and wheel distributions created with the pyproject and hatchling based build system are different than the ones created by the existing setup.py based build system.

The names of the source and wheel distributions created by the python -m build command with these changes
are aeolis-2.1.1-py3-none-any.whl and aeolis-2.1.1.tar.gz, however, the publish-workflow.yml in main searches for the pattern AeoLiS-*.whl during installation test

Can you please update the publish-workflow.yml as part of these changes?

CONTRIBUTING.md Show resolved Hide resolved
@manuGil
Copy link
Collaborator Author

manuGil commented Jun 28, 2023

@niketagrawal I completed the changes. I will merge this PR

@manuGil manuGil self-assigned this Jun 28, 2023
@manuGil manuGil merged commit 01dffe3 into main Jun 28, 2023
3 checks passed
@manuGil manuGil added this to the Handing over milestone Jun 28, 2023
@manuGil manuGil deleted the upgrade/packaging branch July 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants