New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/deprications #128
Patch/deprications #128
Conversation
@manuGil your regarding reading the callback works fine. The callback function is made to interfer with the model parameters on a timestep to timestep basis, adding extra information if that is available. Typical use involves the inclusion of measurement data. To test this, I have created a callback file that can be called in any aeolis input file to test its functionality. State somewhere in the input file: This seems to work. |
Thanks @Sierd It works. I included some test for this function in this RP |
@niketagrawal and @Sierd This should be ready to merge. |
The
imp
built-in package is deprecated. Therefore, this PR substitute it for theimportlib
, as recommended by the Python documentation.AeoLiSRunner.parse_callback()
was modified to used the mportlib package and to raise an exception when an invalid callback file or function is passed by the input (aka. config file).pasre_caback()
were added.Pytest reports other warnings, including the use of
matrix()
instead of the recomendedndarray
. However, this is an issue in the numpy source code and not of AeoLiS