chore(csi-driver): update driver to read PVC, PV name in CreateVolume request #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 4, 2020 18:19
…uest Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 63.88% 63.88%
=======================================
Files 7 7
Lines 335 335
=======================================
Hits 214 214
Misses 108 108
Partials 13 13 Continue to review full report at Codecov.
|
mittachaitu
commented
Jun 4, 2020
payes
approved these changes
Jun 4, 2020
sonasingh46
approved these changes
Jun 5, 2020
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mynktl
approved these changes
Jun 5, 2020
| // volumeCreatedThrough used to identify through which PVC is created | ||
| // NOTE: This annoation will be available on PVC only if velero-plugin | ||
| // creates as PVC as a part of restore request | ||
| volumeCreatedThrough = "openebs.io/created-through" |
There was a problem hiding this comment.
can we move it to openebs/api since this is used in plugin/maya/cstor-operator and here also, better to have it under openebs/api.
There was a problem hiding this comment.
Sure, I need to make similar changes in cstor-operaters repo also. Once this gets PR gets in I will do that.
added 3 commits
June 5, 2020 15:41
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR updates the CSI driver to read PVC name,
PVC namespace, and PV name during CreateVolume
request. If the driver gets PVC name and namespace
it will fetch the entire PVC object from etcd and propagate
the
openebs.io/created-throughannotation to CVC if it existson annotation.
This annotation will inform the CVC controller to create CVR
with annotation
isRestoreVol: true. If this annotation is set thenCVR controller will not the targetIP during zfs dataset creation.
Note:
PVC with the annotation
openebs.io/created-through: restore.extra-create-metadatatocsi-provisionerthen it will send PVC name, namespace and PV name to CSI-dirver
as part of the CreateVolume request.
Reference PR: add pvc metadata to createvolume req kubernetes-csi/external-provisioner#399
Which issue(s) this PR fixes:
Fixes # openebs/openebs#2905
Special notes for your reviewer:
Checklist
documentationtagrequires-upgradetag