Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add support for multiarch build #155

Merged
merged 9 commits into from
Nov 10, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Aug 12, 2020

Signed-off-by: shubham shubham.bajpai@mayadata.io

This PR

  • adds support for multiarch image with the following supported platforms (amd64, arm64, armv7, ppc64le)
  • refactors build script to add new targets to make use of docker buildx
  • adds the following workflows into github actions
    • release
    • ci
    • build

Copy link

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving some thoughts / comments / suggestions.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile.buildx.mk Outdated Show resolved Hide resolved
cspc-operator.Dockerfile Outdated Show resolved Hide resolved
cspc-operator.Dockerfile Outdated Show resolved Hide resolved
cvc-operator.Dockerfile Outdated Show resolved Hide resolved
pool-manager.Dockerfile Outdated Show resolved Hide resolved
volume-manager.Dockerfile Outdated Show resolved Hide resolved
volume-manager.Dockerfile Outdated Show resolved Hide resolved
pool-manager.Dockerfile Outdated Show resolved Hide resolved
@akhilerm akhilerm moved this from RC2 - Due Aug 10, 2020 to Pushed to Next release due to WIP in 2.0 Release Tracker - Due Aug 15th. Aug 13, 2020
@shubham14bajpai shubham14bajpai added this to Pre-commits and Designs - Due: Aug 31 2020 in 2.1 Release Tracker - Released Sep 15th. Aug 19, 2020
@shubham14bajpai shubham14bajpai linked an issue Aug 19, 2020 that may be closed by this pull request
@shubham14bajpai shubham14bajpai removed this from Pre-commits and Designs - Due: Aug 31 2020 in 2.1 Release Tracker - Released Sep 15th. Aug 19, 2020
@akhilerm akhilerm added this to Pre-commits and Designs - Due: Aug 31 2020 in 2.1 Release Tracker - Released Sep 15th. Aug 20, 2020
@sonasingh46 sonasingh46 moved this from Pre-commits and Designs - Due: Aug 31 2020 to RC1 - Due: Sep 5 2020 in 2.1 Release Tracker - Released Sep 15th. Sep 1, 2020
@sonasingh46 sonasingh46 moved this from RC1 - Due: Sep 5 2020 to Pushed to Next release due to WIP in 2.1 Release Tracker - Released Sep 15th. Sep 7, 2020
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Makefile.buildx.mk Outdated Show resolved Hide resolved
Makefile.buildx.mk Outdated Show resolved Hide resolved
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given a few nitpick comments.

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
build/build.sh Outdated Show resolved Hide resolved
build/build.sh Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmova kmova merged commit be2dbc0 into openebs-archive:master Nov 10, 2020
@Abhinandan-Purkait Abhinandan-Purkait removed this from Pushed to Next release due to WIP in 2.0 Release Tracker - Due Aug 15th. Apr 29, 2024
@Abhinandan-Purkait Abhinandan-Purkait removed this from Pushed to Next release due to WIP in 2.1 Release Tracker - Released Sep 15th. Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi arch support for cstor operators images
5 participants