Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[test-case]: Included a test case to verify the pool failure when the disk replacement is in progress #308

Merged
merged 1 commit into from May 4, 2020
Merged

feat[test-case]: Included a test case to verify the pool failure when the disk replacement is in progress #308

merged 1 commit into from May 4, 2020

Conversation

nsathyaseelan
Copy link
Contributor

Signed-off-by: nsathyaseelan sathyaseelan.n@mayadata.io

  • Included a test case to perform the pool failure when the disk replacement is in progress

Checklist

  • Does this PR have a corresponding GitHub issue?
  • Have you included relevant README for the chaoslib/experiment with details?
  • Have you added debug messages where necessary?
  • Have you added task comments where necessary?
  • Have you tested the changes for possible failure conditions?
  • Have you provided the positive & negative test logs for the litmusbook execution?
  • Does the litmusbook ensure idempotency of cluster state?, i.e., is cluster restored to original state?
  • Have you used non-shell/command modules for Kubernetes tasks?
  • Have you (jinja) templatized custom scripts that is run by the litmusbook, if any?
  • Have you (jinja) templatized Kubernetes deployment manifests used by the litmusbook, if any?
  • Have you reused/created util functions instead of repeating tasks in the litmusbook?
  • Do the artifacts follow the appropriate directory structure?
  • Have you isolated storage (eg: OpenEBS) specific implementations, checks?
  • Have you isolated platform (eg: baremetal kubeadm/openshift/aws/gcloud) specific implementations, checks?
  • Are the ansible facts well defined? Is the scope explicitly set for playbook & included utils?
  • Have you ensured minimum/careful usage of shell utilities (awk, grep, sed, cut, xargs etc.,)?
  • Can the limtusbook be executed both from within & outside a container (configurable paths, no hardcode)?
  • Can you suggest the minimal resource requirements for the litmusbook execution?
  • Does the litmusbook job artifact carry comments/default options/range for the ENV tunables?
  • Has the litmusbooks been linted?

Special notes for your reviewer:

@nsathyaseelan nsathyaseelan linked an issue Apr 30, 2020 that may be closed by this pull request
Automate the CSPC Pool failure when the disk replacement is in progress #263
Closed
@nsathyaseelan nsathyaseelan self-assigned this Apr 30, 2020
gprasath
gprasath reviewed Apr 30, 2020
View reviewed changes
experiments/chaos/cspc_pool_failure/disk_replacement_inprogress/README.md Outdated

Type | Description | Storage | K8s Platform |
------|---------------------------------------------------------------|------------|--------------|
Chaos |Delete the cspc pool pod whild Replace the blockdevice/disk in cspc Pool and check the status | OpenEBS | Any |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

experiments/chaos/cspc_pool_failure/disk_replacement_inprogress/test.yml Outdated

- name: Obtain the cspc yaml
shell:
kubectl get cspc -n {{ operator_ns }} -o yaml > ./cspc_disk_replace.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if there are multiple cspc

experiments/chaos/cspc_pool_failure/disk_replacement_inprogress/test.yml Show resolved Hide resolved
experiments/chaos/cspc_pool_failure/disk_replacement_inprogress/test.yml Show resolved Hide resolved
@nsathyaseelan
feat[test-case]: Included atest case to verify the pool failure when …
5e05efe 
…the disk replacement is in progress

Signed-off-by: nsathyaseelan <sathyaseelan.n@mayadata.io>
@gprasath gprasath merged commit 66cfac6 into openebs-archive:master May 4, 2020
@nsathyaseelan nsathyaseelan deleted the cspc-pool-failure branch May 15, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gprasath gprasath gprasath approved these changes

Assignees

@nsathyaseelan nsathyaseelan

Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate the CSPC Pool failure when the disk replacement is in progress
2 participants
@nsathyaseelan @gprasath