feat(BDD): add positive and negative BDD for verifying PDB creation #1606

mittachaitu · 2020-02-05T06:21:48Z

Signed-off-by: mittachaitu sai.chaithanya@mayadata.io

What this PR does / why we need it:
This PR adds positive and negative BDD for PDB creations verifications. Test cases for PR: ##1573

Cmd To Run Negative Test:
Note: This must be run with openebs/cvc-operator:inject-ci
Step1: cd tests/csi/cstor/volume/poddisruptionbudget
Step2: ginkgo -v -focus="\[csi\]\ \[cstor-negative\]" -- -kubeconfig=/home/sai/.kube/config -cstor-maxpools=3 -cstor-replicas=3 -cstor-pool-type=stripe

Running Suite: Test PodDisruptionBudget For CStor Volume
========================================================
Random Seed: 1580882569
Will run 1 of 2 specs

STEP: waiting for maya-apiserver pod to come into running state
STEP: waiting for openebs-provisioner pod to come into running state
STEP: Verifying 'admission-server' pod status as running
STEP: building a namespace
STEP: creating above namespace
S
------------------------------
[csi] [cstor-negative] TEST VOLUME PROVISIONING BY INJECTING ERRORS IN PODDISRUPTIONBUDGET OPERATIONS When HA volume is created by injecting errors in PodDisruptionBudget operations 
  CStorVolumeConfig should be claimed after removing errors
  /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:65
STEP: Creating and verifying cstorpoolcluster
STEP: creating above cstorpoolcluster
STEP: verifying healthy cstorpool count
STEP: Creating storage class
STEP: building a storageclass
STEP: creating above storageclass
STEP: Create service for CVC Operator
STEP: Inject errors in PDB Operations
STEP: creating PVC
STEP: Fetch latest PVC
STEP: Verify CStorVolumeClaim Pending Status
STEP: Eject errors in PDB Operations
STEP: Verify PVC bound state after ejecting the errors
STEP: verifying pvc status as bound
STEP: Verifying the presence of components related to volume
STEP: Verify CStorVolume target pod status
STEP: verifying target pod count as 1 once the app has been deployed
STEP: Verify CStorVolumeReplica count
STEP: Verify CStorVolumeClaim Status
STEP: Verifying the poddisruption budget of volume
STEP: Deleteing service
STEP: Deleting pvc
STEP: verifying deleted pvc
STEP: Verifying deletion of components related to volume
STEP: verifying target pod count as 0
STEP: verifying if cstorvolume is deleted
STEP: Verifying cstorvolume replica count
STEP: Deleting cstorpoolcluster
STEP: deleting cstorpoolcluster
STEP: verifying deleted cspc
STEP: Deleting storage class
STEP: deleting storageclass

• [SLOW TEST:148.815 seconds]
[csi] [cstor-negative] TEST VOLUME PROVISIONING BY INJECTING ERRORS IN PODDISRUPTIONBUDGET OPERATIONS
/home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:54
  When HA volume is created by injecting errors in PodDisruptionBudget operations
  /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:64
    CStorVolumeConfig should be claimed after removing errors
    /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:65
------------------------------
STEP: deleting namespace

Ran 1 of 2 Specs in 152.261 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1 Skipped
PASS

Ginkgo ran 1 suite in 2m36.497971306s
Test Suite Passed

Cmd To Run Positive Test:
Step1: cd tests/csi/cstor/volume/poddisruptionbudget
Step2: ginkgo -v -focus="\[csi\]\ \[cstor\]" -- -kubeconfig=/home/sai/.kube/config -cstor-maxpools=3 -cstor-replicas=3 -cstor-pool-type=stripe

Running Suite: Test PodDisruptionBudget For CStor Volume
========================================================
Random Seed: 1580883142
Will run 1 of 2 specs

STEP: waiting for maya-apiserver pod to come into running state
STEP: waiting for openebs-provisioner pod to come into running state
STEP: Verifying 'admission-server' pod status as running
STEP: building a namespace
STEP: creating above namespace
S
------------------------------
[csi] [cstor] TEST VOLUME PROVISIONING WITH POD DISRUPTION BUDGET When HA volume is created PodDisruptionBudget should be created 
  Volume Should be in Running and PDB should be Created
  /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:45
STEP: Creating and verifying cstorpoolcluster
STEP: creating above cstorpoolcluster
STEP: verifying healthy cstorpool count
STEP: Creating storage class
STEP: building a storageclass
STEP: creating above storageclass
STEP: creating and verifying PVC bound status
STEP: verifying pvc status as bound
STEP: Verifying the presence of components related to volume
STEP: Verify CStorVolume target pod status
STEP: verifying target pod count as 1 once the app has been deployed
STEP: Verify CStorVolumeReplica count
STEP: Verify CStorVolumeClaim Status
STEP: Verifying the poddisruption budget of volume
STEP: Deleting pvc
STEP: verifying deleted pvc
STEP: Verifying deletion of components related to volume
STEP: verifying target pod count as 0
STEP: verifying if cstorvolume is deleted
STEP: Verifying cstorvolume replica count
STEP: Deleting cstorpoolcluster
STEP: deleting cstorpoolcluster
STEP: verifying deleted cspc
STEP: Deleting storage class
STEP: deleting storageclass

• [SLOW TEST:145.891 seconds]
[csi] [cstor] TEST VOLUME PROVISIONING WITH POD DISRUPTION BUDGET
/home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:34
  When HA volume is created PodDisruptionBudget should be created
  /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:44
    Volume Should be in Running and PDB should be Created
    /home/sai/gocode/src/github.com/openebs/maya/tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go:45
------------------------------
STEP: deleting namespace

Ran 1 of 2 Specs in 149.447 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1 Skipped
PASS

Ginkgo ran 1 suite in 2m33.799305308s
Test Suite Passed

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Test cases covered in this PR:

For HA volume(HA volumes means replicaCount >= 3) test will verify whether PDB was created among volume replica pools.
For NonHA volumes verifies whether PDB was created or not(Usually PDB shouldn't be created).
Inject errors in PDB creation to verify whether reconciliation is happening or not for PDB creation.
Checklist:

Fixes #
Labelled this PR & related issue with documentation tag
PR messages has document related information
Labelled this PR & related issue with breaking-changes tag
PR messages has breaking changes related information
Labelled this PR & related issue with requires-upgrade tag
PR messages has upgrade related information
Commit has unit tests
Commit has integration tests

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>

mittachaitu · 2020-02-17T14:52:58Z

tests/csi/cstor/volume/poddisruptionbudget/poddisruption_budget_test.go

+limitations under the License.
+*/
+
+package volume


package name should be updated

shubham14bajpai · 2020-02-18T04:53:31Z

tests/csi/cstor/volume/poddisruptionbudget/suite_test.go

+limitations under the License.
+*/
+
+package volume


package name should be updated

shubham14bajpai

lgtm

mittachaitu · 2020-06-09T05:52:39Z

I was not actively working on this PR. I will re-open when it is required

mittachaitu added 3 commits February 5, 2020 00:57

feat(BDD): add positive and negative BDD for verifying PDB creation

71c1a61

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>

This commit fixes the code comments

59093d9

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>

This commit fixes the isseues in the test code

de0485c

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>

mittachaitu requested review from prateekpandey14, shubham14bajpai and payes February 5, 2020 06:21

mittachaitu self-assigned this Feb 5, 2020

mittachaitu mentioned this pull request Feb 5, 2020

[WIP] feat(PDB, BDD): add test to verify PDB creation #1574

Closed

9 tasks

This commit removes unnecessary changes

575cf70

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>

mittachaitu commented Feb 17, 2020

View reviewed changes

mittachaitu mentioned this pull request Feb 17, 2020

(WIP)feat(BDD): add positive BDD to perform CStorVolumeReplica ScaleUp/ScaleDown #1617

Closed

9 tasks

shubham14bajpai reviewed Feb 18, 2020

View reviewed changes

shubham14bajpai approved these changes Feb 18, 2020

View reviewed changes

mittachaitu closed this Jun 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BDD): add positive and negative BDD for verifying PDB creation #1606

feat(BDD): add positive and negative BDD for verifying PDB creation #1606

mittachaitu commented Feb 5, 2020 •

edited

mittachaitu Feb 17, 2020

shubham14bajpai Feb 18, 2020

shubham14bajpai left a comment

mittachaitu commented Jun 9, 2020

feat(BDD): add positive and negative BDD for verifying PDB creation #1606

feat(BDD): add positive and negative BDD for verifying PDB creation #1606

Conversation

mittachaitu commented Feb 5, 2020 • edited

mittachaitu Feb 17, 2020

Choose a reason for hiding this comment

shubham14bajpai Feb 18, 2020

Choose a reason for hiding this comment

shubham14bajpai left a comment

Choose a reason for hiding this comment

mittachaitu commented Jun 9, 2020

mittachaitu commented Feb 5, 2020 •

edited