fix(policies): support for resource requests on side-cars #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: openebs/openebs#2294 With 0.7.0, there was support for configuring resource limits on the pool and volume pod side-cars using AuxilaryResourceLimits. With this PR, added the support to specify AuxilaryResourceRequests. This feature is useful in cases where user has to specify minimum requests like ephemeral storage etc. to avoid erroneous eviction by K8s as described in the above issue. Also, some of the resource types are very version dependent so keeping this as generic and not providing any defaults in this PR. In the future, it is possible that OpenEBS Operator could automatically determine the version and set default values on the generated default Storage Class. Signed-off-by: kmova <kiran.mova@openebs.io>
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
+ Coverage 42.06% 42.08% +0.02%
==========================================
Files 141 141
Lines 9309 9309
==========================================
+ Hits 3916 3918 +2
+ Misses 5125 5124 -1
+ Partials 268 267 -1
Continue to review full report at Codecov.
|
AmitKumarDas
requested review from
ashishranjan738,
prateekpandey14 and
vishnuitta
vishnuitta
pushed a commit
that referenced
this pull request
Jan 25, 2019
Ref: openebs/openebs#2294 With 0.7.0, there was support for configuring resource limits on the pool and volume pod side-cars using AuxilaryResourceLimits. With this PR, added the support to specify AuxilaryResourceRequests. This feature is useful in cases where user has to specify minimum requests like ephemeral storage etc. to avoid erroneous eviction by K8s as described in the above issue. Also, some of the resource types are very version dependent so keeping this as generic and not providing any defaults in this PR. In the future, it is possible that OpenEBS Operator could automatically determine the version and set default values on the generated default Storage Class. Signed-off-by: kmova <kiran.mova@openebs.io> (cherry picked from commit 9f12a28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: openebs/openebs#2294
With 0.7.0, there was support for configuring resource
limits on the pool and volume pod side-cars using
AuxiliaryResourceLimits. With this PR, added the support
to specify AuxilaryResourceRequests.
This feature is useful in cases where user has to specify
minimum requests like ephemeral storage etc. to avoid
erroneous eviction by K8s as described in the above issue.
Also, some of the resource types are very version dependent
so keeping this as generic and not providing any defaults in
this PR.
In the future, it is possible that OpenEBS Operator could
automatically determine the version and set default values
on the generated default Storage Class.
Signed-off-by: kmova kiran.mova@openebs.io
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: