Fixing Unit test cases.

Signed-off-by: satbir <satbir.singh@mayadata.io>

cmd/controller/disk.go

@@ -44,6 +44,7 @@ type DiskInfo struct {
 	RotationRate       uint16          // 0 = not reported. 1 = SSD, everything else is an RPM
 	Compliance         string          // Compliance is implemented specifications version i.e. SPC-1, SPC-2, etc
 	DiskType           string          // DiskType represents the type of disk like Disk, Sparse etc.,
+	DriveType          string          // DriveType represents the type of disk like HHD, HDD etc.,
 
 	//Stats of disk which keep changing
 	TotalBytesRead        uint64
@@ -158,7 +159,7 @@ func (di *DiskInfo) getDiskDetails() apis.DiskDetails {
 	diskDetails.Vendor = di.Vendor
 	diskDetails.FirmwareRevision = di.FirmwareRevision
 	diskDetails.Compliance = di.Compliance
-	diskDetails.DiskType = di.DiskType
+	diskDetails.DriveType = di.DriveType
 	diskDetails.RotationRate = di.RotationRate
 	return diskDetails
 }

cmd/probe/seachestprobe.go

@@ -155,9 +155,9 @@ func (scp *seachestProbe) FillDiskDetails(d *controller.DiskInfo) {
 		glog.Infof("Disk: %s RotationRate:%d filled by seachest.", d.Path, d.RotationRate)
 	}
 
-	if d.DiskType == "" {
-		d.DiskType = seachestProbe.SeachestIdentifier.IsRotational(driveInfo)
-		glog.Infof("Disk: %s DiskType:%s filled by seachest.", d.Path, d.DiskType)
+	if d.DriveType == "" {
+		d.DriveType = seachestProbe.SeachestIdentifier.IsRotational(driveInfo)
+		glog.Infof("Disk: %s DriveType:%s filled by seachest.", d.Path, d.DriveType)
 	}
 
 	if d.TotalBytesRead == 0 {

pkg/apis/openebs.io/v1alpha1/types.go

@@ -41,7 +41,7 @@ type DiskCapacity struct {
 // DiskDetails contains basic and static info of a disk
 type DiskDetails struct {
 	RotationRate     uint16 `json: "rotationRate"`    // Disk rotation speed if disk is not SSD
-	DiskType         string `json: "DiskType"`        // DiskType represents the type of disk like Disk, Sparse etc.,
+	DriveType        string `json: "driveType"`       // DriveType represents the type of drive like SSD, HDD etc.,
 	Model            string `json:"model"`            // Model is model of disk
 	Compliance       string `json:"compliance"`       // Implemented standards/specifications version such as SPC-1, SPC-2, etc
 	Serial           string `json:"serial"`           // Serial is serial no of disk

pkg/seachest/seachest.go

@@ -34,13 +34,13 @@ package seachest
 import "C"
 import (
 	"fmt"
-	"unsafe"
 	"github.com/golang/glog"
+	"unsafe"
 )
 
 // Seachest errors are converted to string using this function
 func SeachestErrors(err int) string {
-	seachestErrorSting := []string {
+	seachestErrorSting := []string{
 		"Success",
 		"Failed",
 		"Not Supported",
@@ -62,8 +62,8 @@ func SeachestErrors(err int) string {
 		"Cmd Blocked",
 		"Cmd Interrupted",
 		"Unknown",
-         }
-         return seachestErrorSting[err]
+	}
+	return seachestErrorSting[err]
 }
 
 // Identifier (devPath such as /dev/sda,etc) is an identifier for seachest probe
@@ -183,7 +183,7 @@ func (I *Identifier) GetDeviceUtilizationRate(driveInfo *C.driveInformationSAS_S
 }
 
 func (I *Identifier) GetPercentEnduranceUsed(driveInfo *C.driveInformationSAS_SATA) float64 {
-	if (driveInfo.percentEnduranceUsed != -1) {
+	if driveInfo.percentEnduranceUsed != -1 {
 		return ((float64)(driveInfo.percentEnduranceUsed))
 	}
 	return 0