docs: add mount change detection design #594
Conversation
|
|
||
| ## Design | ||
|
|
||
| The mount-points and filesystem info of a block device are found by the probe - *mountprobe*. |
There was a problem hiding this comment.
I checked the findmnt manual page and it says it looks for mount points in /etc/fstab , /etc/mtab and /proc/self/mountinfo . Just wondering if there's a reason NDM should look at fstab or mtab too.
There was a problem hiding this comment.
Not sure if we should be watching fstab/mtab. I took a look at findmnt though. It provides an option to watch for changes (-p). To implement this, it also uses the linux polling api and by default watches for changes in /proc/self/mountinfo.
There was a problem hiding this comment.
Cool, that's good validation. We can add watching fstab/mtab if the need ever arises I suppose. Right now, don't see a reason we need it
akhilerm
added this to Pre-commits and Designs - Due: May 31 2021
in 2.10 Release Tracker - Due June 15th.
z0marlin
changed the title
There was a problem hiding this comment.
Provide a note in the design:
filesystem changes can be detected only once the device is mounted. If just format a filesystem on the device and does not mount it, it wont be updated.
@z0marlin Have one comment on using the existing mountprobe itself. everything else looks good. Can proceed with implementation
nsathyaseelan
moved this from Pre-commits and Designs - Due: May 31 2021
to RC2 - Due: Jun 8 2021
in 2.10 Release Tracker - Due June 15th.
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
kmova
moved this from RC2 - Due: Jun 8 2021
to Pushed to Next release due to WIP
in 2.10 Release Tracker - Due June 15th.
kmova
added this to Pre-commits and Designs - Due: May 31 2021
in 2.11 Release Tracker - Due July 15th.
prateekpandey14
moved this from Pre-commits and Designs - Due: June 30 2021
to RC1 - Due: Jul 3 2021
in 2.11 Release Tracker - Due July 15th.
prateekpandey14
moved this from RC1 - Due: Jul 3 2021
to RC2 - Due: Jul 8 2021
in 2.11 Release Tracker - Due July 15th.
prateekpandey14
moved this from RC2 - Due: Jul 8 2021
to RC1 - Due: Jul 3 2021
in 2.11 Release Tracker - Due July 15th.
prateekpandey14
moved this from RC1 - Due: Jul 3 2021
to RC2 - Due: Jul 8 2021
in 2.11 Release Tracker - Due July 15th.
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
prateekpandey14
moved this from RC2 - Due: Jul 8 2021
to Release Items
in 2.11 Release Tracker - Due July 15th.
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com> Co-authored-by: Akhil Mohan <akhilerm@gmail.com>
Abhinandan-Purkait
removed this from Pushed to Next release due to WIP
in 2.10 Release Tracker - Due June 15th.
Checklist:
<type>(<scope>): <subject>