Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(probe): update bd cache after generating uuid #602

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

z0marlin
Copy link
Contributor

@z0marlin z0marlin commented Jul 7, 2021

when adding a blockdevice, the information stroed in the controller
cache does not contain the the up to date uuid of the bd generated while
adding the bd. Update the bd cache with the new uuid after generation.

Signed-off-by: Aditya Jain aditya.jainadityajain.jain@gmail.com

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them

when adding a blockdevice, the information stroed in the controller
cache does not contain the the up to date uuid of the bd generated while
adding the bd. Update the bd cache with the new uuid after generation.

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm merged commit e9ce0d7 into openebs-archive:master Jul 8, 2021
z0marlin added a commit to z0marlin/node-disk-manager that referenced this pull request Jul 8, 2021
remove FIXME since openebs-archive#602 was merged

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
@z0marlin z0marlin deleted the fix-add-cache branch October 12, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants