Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(probe): add size change detection #616

Merged
merged 20 commits into from
Sep 6, 2021
Merged

feat(probe): add size change detection #616

merged 20 commits into from
Sep 6, 2021

Commits on Sep 6, 2021

  1. feat(probe): add blockdevice size change detection using udev 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    66215cf View commit details
    Browse the repository at this point in the history

  2. fix(probe, sysfs): remove zero value check when filling bd capacity 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    a1899b8 View commit details
    Browse the repository at this point in the history

  3. test: add integration tests for size change detection 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    aabc3aa View commit details
    Browse the repository at this point in the history

  4. test: fix size change integration test 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    544142e View commit details
    Browse the repository at this point in the history

  5. refactor(probe): move change event processing from sysfs to udev probe 

    process all udev events, including change events in udev probe alone
instead of processing them in other probes. The udev probe alone can
send out required event message after processing the change events.
Since the remaining two types - add and remove are also handled by udev
probe, keeping the third type (change) too in the same probe is cleaner
and logical.

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    f359e3c View commit details
    Browse the repository at this point in the history

  6. fix(probe): add checks in change handler to prevent extra api calls 

    the change handling mechanism is currently used to detect changes
in blockdevice size, filesystem, and mount-points. Add checks to prevent
calls to the kube api server in case any of these fields haven't changed
after re-filling the blockdevice details using the probes.

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    b26ef96 View commit details
    Browse the repository at this point in the history

  7. add feature gate for size change detection 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    91cbd1e View commit details
    Browse the repository at this point in the history

  8. merge SizeChangeDection and MountChangeDetection feature flags 

    merge the two flags into a single flag - `ChangeDetection`

Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    8b0ee1c View commit details
    Browse the repository at this point in the history

  9. replace MountEA with ChangeEA 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    d09416c View commit details
    Browse the repository at this point in the history

  10. rename vairable for clarity 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    15ad2aa View commit details
    Browse the repository at this point in the history

  11. style(probe): move parameters to separate lines 

    Co-authored-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin @akhilerm
    z0marlin and akhilerm committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    79e8703 View commit details
    Browse the repository at this point in the history

  12. chore: update manifest 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    be66f0c View commit details
    Browse the repository at this point in the history

  13. chore: update unreleased changelog 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    a278b72 View commit details
    Browse the repository at this point in the history

  14. chore: fix deploy manifest 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    c9405f8 View commit details
    Browse the repository at this point in the history

  15. fix(probe): do not process change event if bd not in cache 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    47f61c0 View commit details
    Browse the repository at this point in the history

  16. fix(probe): reset err when change skipped 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    045c9f8 View commit details
    Browse the repository at this point in the history

  17. fix typo 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    05eed8a View commit details
    Browse the repository at this point in the history

  18. refactor(probe): add log line for mount/fs changes in mount probe 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    138a03f View commit details
    Browse the repository at this point in the history

  19. check only required bd for active status 

    Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
    @akhilerm @z0marlin
    akhilerm authored and z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    ae17aa0 View commit details
    Browse the repository at this point in the history

  20. use buffered epoll to prevent loss of epoll events 

    Signed-off-by: Aditya Jain <aditya.jainadityajain.jain@gmail.com>
    @z0marlin
    z0marlin committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    b5778d7 View commit details
    Browse the repository at this point in the history