Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): address CVE-2021-4238 from github.com/Masterminds/goutils #171

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

cmontemuino
Copy link
Contributor

Pull Request template

Why is this PR required? What issue does it fix?:

Removes vulnerability CVE-2021-4238

What this PR does?:

github.com/Masterminds/goutils v1.1.0 comes with vulnerability CVE-2021-4238. It is an indirect dependency from github.com/openebs/maya.

Best approach would be to upgrade maya dep, but this project is not being actively maintain (last release from 2021).

A second alternative is to replace the library github.com/Masteminds/sprig, but it uses goutils v1.1.1 only after version v3.2.1. The version change is too big.

The less intrusive approach is to replace gotutils version.

Does this PR require any upgrade changes?:

No.

If the changes in this PR are manually verified, list down the scenarios covered::

# Identify from where the github.com/Mastermind/goutils originates
go mod why github.com/Mastermind/gotuils
# Make the change and update deps
make deps
# Verify the replace takes place
go list -m all | grep Masterminds
# Run tests
make tests

Any additional information for your reviewer? :

No.

Checklist:

github.com/Masterminds/goutils v1.1.0 comes with vulnerability CVE-2021-4238.
It is an indirect dependency from  github.com/openebs/maya.
Best approach would be to upgrade maya dep, but this project is not being
actively maintain (last release from 2021).

A second alternative is to replace the library github.com/Masteminds/sprig, but
it uses goutils v1.1.1 only after version v3.2.1. The version change is too big.

The less intrusive approach is to replace gotutils version.

Fixes openebs#170

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
@cmontemuino
Copy link
Contributor Author

cc @niladrih

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (badb4c0) 38.03% compared to head (1621c83) 38.03%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #171   +/-   ##
========================================
  Coverage    38.03%   38.03%           
========================================
  Files           36       36           
  Lines         3363     3363           
========================================
  Hits          1279     1279           
  Misses        2002     2002           
  Partials        82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niladrih niladrih merged commit 4123f5f into openebs:develop Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Critical vulnerability CVE-2021-4238 from Masterminds/goutils package 1.1.0
3 participants