revert!: disable device localpv #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
requested review from
niladrih,
avishnu and
tiagolobocastro
Abhinandan-Purkait
force-pushed
the
disable-localpv-device
branch
from
6dbdaaa
to
c8f03aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #172 +/- ##
===========================================
+ Coverage 38.03% 38.20% +0.17%
===========================================
Files 36 36
Lines 3363 3348 -15
===========================================
Hits 1279 1279
+ Misses 2002 1987 -15
Partials 82 82 ☔ View full report in Codecov by Sentry. |
Abhinandan-Purkait
force-pushed
the
disable-localpv-device
branch
10 times, most recently
from
fa653a7
to
569b939
Compare
niladrih
reviewed
Mar 1, 2024
niladrih
reviewed
Mar 7, 2024
Have already removed it. Should I remove the |
tiagolobocastro
approved these changes
Mar 7, 2024
Abhinandan-Purkait
changed the title
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
force-pushed
the
disable-localpv-device
branch
from
8212959
to
0443601
Compare
Yes, it won't work I think. |
niladrih
approved these changes
Mar 7, 2024
Abhinandan-Purkait
force-pushed
the
disable-localpv-device
branch
from
b0175b5
to
0443601
Compare
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATE LOCAL-PV DEVICE
This PR includes the bits that would contribute to the deprecation of localpv device. Henceforth all the dependent charts needed for localpv device ex. NDM would be removed. Provisioning and de-provisioning of local device volumes will no longer be supported.
Since this is a breaking change, we are bumping up the major version from 3.5.x to 4.0.x.