Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Makefile/buildscript): Clean up traces of travis workflow from makefile and buildscript #59

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

niladrih
Copy link
Member

Signed-off-by: Niladri Halder niladri.halder@mayadata.io

Changes:

  • Does not export few variables as it is not required anymore.
  • Buildx workflow uses the same variables as used for host OS/arch build.
  • removed generation of BUILDMETA from buildscript
  • Deleted BUILDMETA and VERSION files.

Also in this PR:

  • Created pkg/version/version.go to track version and latest GitCommit hash.

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@codecov-commenter
Copy link

Codecov Report

Merging #59 (0fa551f) into develop (e57d017) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #59   +/-   ##
========================================
  Coverage    34.60%   34.60%           
========================================
  Files           27       27           
  Lines         2124     2124           
========================================
  Hits           735      735           
  Misses        1352     1352           
  Partials        37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57d017...0fa551f. Read the comment docs.

@niladrih
Copy link
Member Author

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

Have put up a question / suggestion in the comment section

@prateekpandey14 prateekpandey14 moved this from Release Items to Pushed to Next release due to WIP in 2.10 Release Tracker - Due June 15th. Jun 15, 2021
@kmova kmova added this to Pre-commits and Designs - Due: May 31 2021 in 2.11 Release Tracker - Due July 15th. Jun 15, 2021
@akhilerm akhilerm merged commit 0dc3ff8 into openebs:develop Jun 22, 2021
2.10 Release Tracker - Due June 15th. automation moved this from Pushed to Next release due to WIP to Done Jun 22, 2021
2.11 Release Tracker - Due July 15th. automation moved this from Pre-commits and Designs - Due: June 30 2021 to Done Jun 22, 2021
@niladrih niladrih deleted the makefile branch June 22, 2021 14:13
niladrih added a commit that referenced this pull request Jun 28, 2024
…files (#59)

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants