[TA4284] fix(rpc): close connection at the client side

[utkarshmani1997]

Controller initiates a new connection upon replica registration,
this might create some problem due to concurrent goroutines, as some
of the goroutine may not have been exited. To ensure graceful close
of the connection, i have added CloseRead and CloseWrite in both
replica and controller.

Earlier we were not logging error in replica in such scenario, an error will be logged after this fix.

Signed-off-by: Utkarsh Mani Tripathi utkarsh.tripathi@mayadata.io

[vishnuitta]

Please try code as below to make sure GO routines are exited:

diff --git a/rpc/client.go b/rpc/client.go
index 6fc1a75..6fb8ce8 100644
--- a/rpc/client.go
+++ b/rpc/client.go
@@ -70,6 +70,8 @@ func NewClient(conn net.Conn, closeChan chan struct{}) *Client {
                messages:  map[uint32]*Message{},
                closeChan: closeChan,
        }
+       c.write_exited = false
+       c.read_exited = false
        go c.loop()
        go c.write()
        go c.read()
@@ -221,6 +223,17 @@ func (c *Client) Close() {
 
 func (c *Client) loop() {
        defer close(c.send)
+       defer func() {
+               c.wire.CloseRead()
+               c.wire.CloseWrite()
+               for {
+                       if (c.read_exited == true) && (c.write_exited == true) {
+                               break
+                       }
+                       time.Sleep()
+               }
+               c.wire.Close()
+       }
 
        for {
                select {
@@ -317,6 +330,7 @@ func (c *Client) write() {
                }
        }
        logrus.Infof("Exiting rpc writer, RemoteAddr:%v", c.peerAddr)
+       c.write_exited = true
 }
 
 func (c *Client) read() {
@@ -330,4 +344,5 @@ func (c *Client) read() {
                c.responses <- msg
        }
        logrus.Infof("Exiting rpc reader, RemoteAddr:%v", c.peerAddr)
+       c.read_exited = true
 }

[vishnuitta]

changes are good