feat(NodeController): made node polling interval configurable #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omric-runai
force-pushed
the
omric/node-polling-interval
branch
from
3bc0c8c
to
9e2bebc
Compare
Signed-off-by: Omri Cohen <omri.cohen@run.ai>
omric-runai
force-pushed
the
omric/node-polling-interval
branch
from
9e2bebc
to
b283985
Compare
|
Hi @omric-runai , Thanks for the PR. lgtm |
abhilashshetty04
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
@avishnu @abhilashshetty04 Since this is configurable, I think we need a helm value and template change to accommodate this?
avishnu
reviewed
Sep 7, 2023
Yes, we need a configurable parameter in the helm values.yaml |
… Start Signed-off-by: Omri Cohen <omri.cohen@run.ai>
omric-runai
force-pushed
the
omric/node-polling-interval
branch
from
05695bd
to
0f543ac
Compare
|
@omric-runai Thanks for the PR. Would you be interested in raising a helm chart change for allowing configuring this from Helm Chart? You can raise a separate PR for that if you want. |
Abhinandan-Purkait
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
This PR makes the polling interval of the node configurable, allowing users to get a higher update rate for their csistoragecapacities, and preventing scheduling issue.
What this PR does?:
This PR adds a new flag,
--node-polling-interval, with a default value of 60s (same as the currant hard-coded value), which controls the polling rate of the node.Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
N/A
Checklist:
<type>(<scope>): <subject>