Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Change lvm-controller's Kind from StatefulSet to Deployment (#196) #258

Closed
wants to merge 3 commits into from

Conversation

evgkrsk
Copy link
Contributor

@evgkrsk evgkrsk commented Sep 22, 2023

Pull Request template

Why is this PR required? What issue does it fix?:

This PR address #196 issue and tries to avoid lvm-controller's disruption if underlaying node(s) crashed. Deployment's controller will restart failed pod(s) on healthy node, unlike StatefulSet's controller.

What this PR does?:

It change lvm-controller's Kind from StatefuleSet to Deployment.

Does this PR require any upgrade changes?:

No, as far as I know.

If the changes in this PR are manually verified, list down the scenarios covered::

  • Helm release migration from sts to deployment (LE, 2 replicas).

Checklist:

)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Evgenii Tereshkov <evg.krsk@gmail.com>
@Abhinandan-Purkait
Copy link
Member

Closing since it's cherry-picked in #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does openebs-lvm-controller use StatefulSet ?
2 participants