chore(helm): helm changes with version bump #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hyphen at the end of the closing brackets is responsible for chomping all the whitespaces after the brackets. Thus, a previous YAML separator gets into the same line as the `apiVersion` element from the resource enable by the `if` statement. fixes #271 Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
Some description tags had an invalid structure for multi line strings. For Example: ```yaml description: 'Some description` ``` Multi line single quoted flows require at least 1 level of indentation or else a parser should treat the first word on the new line as an implicit key. Valid example: ```yaml description: 'Some description' ``` Signed-off-by: Max Rose <max.rose366@gmail.com>
Signed-off-by: Max Rose <max.rose366@gmail.com>
Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
abhilashshetty04
requested review from
niladrih,
Abhinandan-Purkait and
avishnu
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
approved these changes
Dec 7, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Includes cherry pick of #270 and #272 along with rbac secret removal.
Checklist:
<type>(<scope>): <subject>