Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cvr delete, finalizer): remove finalizers to ensure successful de…
…letion This commit removes the finalizers from a cstor volume replica object. This ensures removal of cstor volume replica object from kubernetes. In addition, it will try to delete the underlying volume if cvr controller gets the delete event. With the removal of finalizer there is no more retry mechanism to actually delete the underlying volume if there were issues encountered during earlier deletes. Why was finalizer put in first place? CstorVolumeReplica aliased CVR has finalizers that prohibits deletion unless the volume gets deleted. This is a check to ensure proper cleanup even if delete events are missed & / or underlying volume was not deleted in earlier attempts. Observations: There were observations that point to the fact that when the namespace (that contains these volumes) as well when the operator (that contains the CRD schema definitions) are deleted, CVR finalizers pose a significant problem to the overall deletion & later re-creation procedure. In fact the PODs that are responsible for actual volume deletion & confirming the delete status is no more available when its namespace or the openebs operator get deleted. Future Work: A better design needs to be implemented that ensures volume cleanup & hence space reclamation. fixes openebs/openebs#2374 fixes openebs/openebs#2349 Signed-off-by: AmitKumarDas <amit.das@mayadata.io>
- Loading branch information