cherrypick(fix, cvr, delete): add finalizer to reclaim space on volume delete #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enebs#1256) This commit reverts a previous commit i.e. openebs#955 There were a few observations (that were expected) due to above commit. CVR used to have finalizers to execute cleanup operations due to delete event of corresponding volume. This is a standard practice in kubernetes community to handle cleanups via reconciliation process. However, we had to remove finalizers as seen in the commit 955 due to various reasons. These were: [1] Inability to delete a openebs system namespace and expect entire openebs to get uninstalled [2] Deletion of cstor volume did not delete CVRs due to the presence of finalizers. This was seen most of the times across various users and platforms. This was not easily reproducible in development environments. With the current release i.e. 0.9.0 some users have started to face issues like space not getting reclaimed even after cstor volumes get deleted successfully. On further analysis, it was found that user had tried following operation: `kubectl delete pvc --all -n some-namespace` which led to deletion of pvc, pv, cv, cvr resources from k8s cluster but corresponding events especially cvr based events were received much later at the controller code. This resulted in `cvr resource not found` and hence these resources were not cleaned up successfully leading to space issues. With this fix we expect original symptoms to recur. However, we plan to provide another fix after the automated test suite is able to discover these issues at will. This next fix will deal only with symptom '2' NOTE: Ability to un-install openebs by deleting openebs system namespace needs to be handled by a higher order logic/process. This is now considered as out of scope w.r.t cvr controller. Signed-off-by: AmitKumarDas <amit.das@mayadata.io>
AmitKumarDas
added
BUG
component: CStorPoolMgmt
component: CStorVolMgmt
pr/upgrade-changes-pending
AmitKumarDas
requested review from
sonasingh46,
mittachaitu,
kmova and
vishnuitta
prateekpandey14
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cherrypick of #1256