-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Lint Issues #149
Fixing Lint Issues #149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 17.63% 17.63%
=======================================
Files 55 55
Lines 7157 7157
=======================================
Hits 1262 1262
Misses 5803 5803
Partials 92 92
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs test!, lgtm
command/install.go
Outdated
func (c *MayaAsNomadInstaller) Install() int { | ||
|
||
var runop int | ||
|
||
if runop = c.verifyBootstrap(); runop != 0 { | ||
//Run the bootstrap only if required | ||
//Run the bootstrap only if reqUIred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n_ reqUIred -> required.
sounds like a global replace of ui to UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh my bad
Thanks @ggarg2906sumo for your help. |
Thanks @ggarg2906sumo squashed and merged |
Fixing Lint Issues * Bug Fixes for previous commits * Fixed typo
Issue -780
Fixing Lint in maya/command/install.go