Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Lint Issues #149

Merged
merged 3 commits into from
Oct 29, 2017

Conversation

ggarg2906sumo
Copy link
Contributor

Issue -780
Fixing Lint in maya/command/install.go

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          55       55           
  Lines        7157     7157           
=======================================
  Hits         1262     1262           
  Misses       5803     5803           
  Partials       92       92
Impacted Files Coverage Δ
command/install_openebs.go 0% <0%> (ø) ⬆️
command/install.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ba471...cb15859. Read the comment docs.

Copy link
Contributor

@satyamz satyamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs test!, lgtm

func (c *MayaAsNomadInstaller) Install() int {

var runop int

if runop = c.verifyBootstrap(); runop != 0 {
//Run the bootstrap only if required
//Run the bootstrap only if reqUIred
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_ reqUIred -> required.

sounds like a global replace of ui to UI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh my bad

@prateekpandey14
Copy link
Contributor

Thanks @ggarg2906sumo for your help.
Please squash the commits to 1 commit .

@prateekpandey14 prateekpandey14 merged commit 3b513df into openebs-archive:master Oct 29, 2017
@prateekpandey14
Copy link
Contributor

Thanks @ggarg2906sumo squashed and merged

keydrevolta pushed a commit to keydrevolta/maya that referenced this pull request Oct 29, 2017
Fixing Lint Issues

* Bug Fixes for  previous commits

* Fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants