New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Lint Issues #149

Merged
merged 3 commits into from Oct 29, 2017

Conversation

Projects
None yet
4 participants
@ggarg2906sumo
Contributor

ggarg2906sumo commented Oct 28, 2017

Issue -780
Fixing Lint in maya/command/install.go

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 28, 2017

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          55       55           
  Lines        7157     7157           
=======================================
  Hits         1262     1262           
  Misses       5803     5803           
  Partials       92       92
Impacted Files Coverage Δ
command/install_openebs.go 0% <0%> (ø) ⬆️
command/install.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ba471...cb15859. Read the comment docs.

codecov bot commented Oct 28, 2017

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files          55       55           
  Lines        7157     7157           
=======================================
  Hits         1262     1262           
  Misses       5803     5803           
  Partials       92       92
Impacted Files Coverage Δ
command/install_openebs.go 0% <0%> (ø) ⬆️
command/install.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ba471...cb15859. Read the comment docs.

@satyamz

Needs test!, lgtm

Show outdated Hide outdated command/install.go Outdated
@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 29, 2017

Member

Thanks @ggarg2906sumo for your help.
Please squash the commits to 1 commit .

Member

prateekpandey14 commented Oct 29, 2017

Thanks @ggarg2906sumo for your help.
Please squash the commits to 1 commit .

@prateekpandey14 prateekpandey14 merged commit 3b513df into openebs:master Oct 29, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 17.63%)
Details
codecov/project 17.63% remains the same compared to b8ba471
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prateekpandey14

This comment has been minimized.

Show comment
Hide comment
@prateekpandey14

prateekpandey14 Oct 29, 2017

Member

Thanks @ggarg2906sumo squashed and merged

Member

prateekpandey14 commented Oct 29, 2017

Thanks @ggarg2906sumo squashed and merged

keydrevolta added a commit to keydrevolta/maya that referenced this pull request Oct 29, 2017

Fixing Lint Issues (openebs#149)
Fixing Lint Issues

* Bug Fixes for  previous commits

* Fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment