Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#785 add command unit test #253

Merged
merged 1 commit into from Feb 1, 2018
Merged

#785 add command unit test #253

merged 1 commit into from Feb 1, 2018

Conversation

caugello
Copy link
Contributor

What this PR does / why we need it:

Unit test for maya-apiserver cmd. (commands.go)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes: openebs/785

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #253 into master will increase coverage by 0.85%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   26.26%   27.11%   +0.85%     
==========================================
  Files          43       43              
  Lines        3739     3739              
==========================================
+ Hits          982     1014      +32     
+ Misses       2644     2610      -34     
- Partials      113      115       +2
Impacted Files Coverage Δ
cmd/maya-apiserver/app/command/start.go 9.84% <0%> (+9.84%) ⬆️
cmd/maya-apiserver/app/command/version.go 50% <0%> (+50%) ⬆️
cmd/maya-apiserver/app/command/commands.go 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9138a9...45c039c. Read the comment docs.

Copy link
Member

@kmova kmova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kartouch

@kmova kmova merged commit 36e4856 into openebs:master Feb 1, 2018
@nitisuryawanshi
Copy link

@kartouch thank you for your contribution to OpenEBS. We would like to send you some OpenEBS Swag as a thank you note from the OpenEBS team. Will you please fill out this form with your details so that we start processing it ASAP? https://cloudbyte.agilecrm.com/forms/5126296610799616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CODECOV] Write unit tests for maya-apiserver's app/command/commands.go file
3 participants