Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade-job): add version info log #276

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

niladrih
Copy link
Member

Adds version log when initializing.

@niladrih
Copy link
Member Author

bors try

bors bot pushed a commit that referenced this pull request Jun 30, 2023
@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih
Copy link
Member Author

bors try

bors bot pushed a commit that referenced this pull request Jun 30, 2023
@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@tiagolobocastro
Copy link
Contributor

Btw once we have cli args this can also be useful? Example:

println!("Using options: {:?}", &cli_args);

@niladrih
Copy link
Member Author

bors merge

@niladrih
Copy link
Member Author

Btw once we have cli args this can also be useful? Example:

println!("Using options: {:?}", &cli_args);

That's a good idea..

@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d647d3a into openebs:develop Jun 30, 2023
5 checks passed
bors bot pushed a commit that referenced this pull request Jun 30, 2023
277: Cherry-pick #276 into release/2.3 branch r=niladrih a=niladrih



Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants