fix(upgrade-job): avoid infinite loop when no unhealthy vols have a target #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
sinhaashish,
hrudaya21,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
Abhinandan-Purkait
approved these changes
Dec 26, 2023
…arget Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
force-pushed
the
upgrade-fix
branch
from
ed4fb02
to
c0096f6
Compare
tiagolobocastro
approved these changes
Dec 27, 2023
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if, during data-plane upgrade,
rebuild_resultfunction finds unhealthy volumes, but none of the volumes have a target, then, the function continues to try to list unhealthy volumes constantly.Adds a break from the infinite loop for an empty target accumulator.
Description
Adds a break from the infinite loop for an empty target hashset.
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: