feat(eventing): add k8sClusterDomain default value to nats config #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datacore-vvarakantham
requested review from
tiagolobocastro,
Abhinandan-Purkait and
sinhaashish
niladrih
approved these changes
Apr 2, 2024
Signed-off-by: Vandana Varakantham <vandana.varakantham@datacore.com>
datacore-vvarakantham
force-pushed
the
nats-cluster-domain-config
branch
from
5d6f750
to
e74f030
Compare
tiagolobocastro
approved these changes
Apr 10, 2024
|
@niladrih do we need upgrade job changes for this? |
|
Build succeeded: |
datacore-vvarakantham
added a commit
to datacore-vvarakantham/mayastor-extensions
that referenced
this pull request
Apr 10, 2024
421: feat(eventing): add k8sClusterDomain default value to nats config r=tiagolobocastro a=datacore-vvarakantham <! Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
|
@tiagolobocastro New values are file. No changes needed for upgrade. |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
478: Cherry-pick PR #421 r=datacore-vvarakantham a=datacore-vvarakantham Set 'useFQDN' to 'false' in Nats config in values.yaml. Now NATS uses short names to refer to other pods within the same namespace - No domain suffix. <! Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
478: Cherry-pick PR #421 r=datacore-vvarakantham a=datacore-vvarakantham Set 'useFQDN' to 'false' in Nats config in values.yaml. Now NATS uses short names to refer to other pods within the same namespace - No domain suffix. <! Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set 'useFQDN' to 'false' in Nats config in values.yaml. Now NATS uses short names to refer to other pods within the same namespace - No domain suffix.
Description
Motivation and Context
To make it clear of the default value being used for K8sClusterDomain in NATS config.
Regression
How Has This Been Tested?
Types of changes
Checklist: