feat(charts): add values to control etcd and loki hostpath sc creation #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
requested review from
tiagolobocastro,
niladrih and
avishnu
and removed request for
tiagolobocastro
Abhinandan-Purkait
force-pushed
the
helm_changes
branch
from
15ab625
to
8a878af
Compare
tiagolobocastro
approved these changes
Mar 8, 2024
niladrih
requested changes
Mar 8, 2024
Abhinandan-Purkait
force-pushed
the
helm_changes
branch
3 times, most recently
from
f4630e9
to
897e42d
Compare
niladrih
reviewed
Mar 14, 2024
Abhinandan-Purkait
force-pushed
the
helm_changes
branch
from
897e42d
to
a5bec14
Compare
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Abhinandan-Purkait
force-pushed
the
helm_changes
branch
from
a5bec14
to
0d1971b
Compare
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
451: Cherry-pick #432 r=niladrih a=Abhinandan-Purkait - add values to control etcd and loki hostpath sc creation Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
etcd.localpvScConfig.enabledandloki-stack.localpvScConfig.enabledvalues so that we can control the creation of storage classes for etcd and loki, for cases when localpv is installed from the umbrella helm chart.