Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubectl/dump/etcd): use correct namespace #437

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(kubectl/dump/etcd): use correct namespace #437

merged 1 commit into from
Mar 18, 2024

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Mar 14, 2024 •
edited

Etcd dump failing since an etcd bugfix, which had etcd return all data rather than keys matching a prefix.

Description

Namespace for etcd is not available in k8s env variables as the plugin runs outside the cluster.
A better solution is perhaps to simply ensure we create clients with the correct namespace as default?

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@tiagolobocastro
fix(kubectl/dump/etcd): use correct namespace
fdef22a 
When we run outside of the cluster, we can't just use the env to determine
the correct namespace..
A better solution is perhaps to simply ensure we create clients with the
correct namespace as default?

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit c63fe2c into develop Mar 18, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the etcd branch March 18, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@niladrih niladrih niladrih approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@datacore-vvarakantham datacore-vvarakantham Awaiting requested review from datacore-vvarakantham

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tiagolobocastro @Abhinandan-Purkait @niladrih