Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(chart): update topology segments usage #439

Merged
merged 1 commit into from
Mar 21, 2024
Merged

docs(chart): update topology segments usage #439

merged 1 commit into from
Mar 21, 2024

Conversation

cmontemuino
Copy link
Contributor

Description

Extend the nodeSelector documentation with a note that agent-ha-node node selector will be also updated with topology segments

Motivation and Context

It is not clear that csi.node.topology.nodeSelector is also impacting agent-ha-node daemonset.

openebs/mayastor#1605

Regression

No

How Has This Been Tested?

Types of changes

It's documentation change only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@cmontemuino cmontemuino mentioned this pull request Mar 15, 2024
Closed
@cmontemuino
docs(chart): update topology segments usage
16b7626 
Problem: It is not clear that `csi.node.topology.nodeSelector` is also
impacting agent-ha-node daemonset

Solution: Extend the `nodeSelector` documentation with a note that
agent-ha-node node selector will be also updated with topology segments

Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
@niladrih
Copy link
Member

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit f6f12db into openebs:develop Mar 21, 2024
5 checks passed
@niladrih niladrih mentioned this pull request Mar 21, 2024
Merged
bors-openebs-mayastor bot pushed a commit that referenced this pull request Mar 21, 2024
@cmontemuino @niladrih
chore(bors): merge pull request #450
9a5eec2 
450: Cherry-pick #438 and #439 r=niladrih a=niladrih

This PR cherry-picks the commits from the following PRs to release/2.6 branch:
- #438 
- #439 

Co-authored-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@niladrih niladrih niladrih approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cmontemuino @niladrih @tiagolobocastro