feat(chart): prevent CRDs from being recycled #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: with current implementation a chart uninstal also removes the CRDs, which triggers deletion of all created CRs. Solution: add a configuration to keep CRDs by default, instructing Helm to not delete such resources. Also add the possibility to specify extra annotations. This is especially interesting for Argo CD users, as Argo CD does not install charts the Helm way. In such a case, an extra annotation to prevent prunning resources is required. Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
7 tasks
Problem: the crdIsAbsent check is preventing to upgrade CRDs Solution: remove the check and rely on `crds.xxx.enabled` property instead. This should be a conscious decicion made by users anyways. Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
tiagolobocastro
approved these changes
Mar 27, 2024
Abhinandan-Purkait
approved these changes
Mar 27, 2024
|
thanks @cmontemuino! |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
458: feat(chart): prevent CRDs from being recycled r=tiagolobocastro a=cmontemuino <! Co-authored-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
|
Build failed: |
|
@cmontemuino could you please re-run the helm doc generator, here's the failure from CI: |
Signed-off-by: cmontemuino <1761056+cmontemuino@users.noreply.github.com>
|
bors try |
tryBuild succeeded: |
|
Thanks @cmontemuino. Are we good to merge now? |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With current implementation a chart uninstall also removes the CRDs, which triggers deletion of all created CRs.
Motivation and Context
Add a configuration to keep CRDs by default, instructing Helm to not delete such resources. Also add the possibility to specify extra annotations. This is especially interesting for Argo CD users, as Argo CD does not install charts the Helm way. In such a case, an extra annotation to prevent prunning resources is required.
Regression
How Has This Been Tested?
Case 1: keep all CRDs
Case 2: keep CSI VolumeSnaphots CRDs only
Case 3: keep Jaeger CRDs only
Types of changes
Checklist: