Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partial rebuild disable and various fixes #471

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Add partial rebuild disable and various fixes #471

merged 5 commits into from
Apr 10, 2024

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Apr 8, 2024 •
edited 

feat(helm): add var to disable partial rebuilds

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

fix(helm): unbound helm var access

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

ci: printenv before image build test

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

ci(release/script): avoid unbound var access

Ensure helm dep var is set before we use it (cleanup).
Rename it to capitals to make clear its global.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

ci(helm/devel-rel): don't die when already in rel

When we're already in the release branch, don't fail.
On the other hand, do fail if on a different version.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

@tiagolobocastro
ci(helm/devel-rel): don't die when already in rel
858e066 
When we're already in the release branch, don't fail.
On the other hand, do fail if on a different version.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
ci(release/script): avoid unbound var access
592aed7 
Ensure helm dep var is set before we use it (cleanup).
Rename it to capitals to make clear its global.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
ci: printenv before image build test
d3819f5 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
fix(helm): unbound helm var access
f65738b 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro tiagolobocastro changed the title ci(helm/devel-rel): don't die when already in release Add partial rebuild disable and various fixes Apr 10, 2024
@tiagolobocastro
feat(helm): add var to disable partial rebuilds
e773891 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit b9c0d3c into develop Apr 10, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the fix-helm branch April 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisedias blaisedias blaisedias approved these changes

@niladrih niladrih niladrih approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

@w3aman w3aman Awaiting requested review from w3aman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tiagolobocastro @blaisedias @niladrih