fix(jaeger): update and use the jaeger bundled CRD #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
avishnu,
blaisedias,
sinhaashish,
Abhinandan-Purkait,
w3aman and
niladrih
It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
jaeger-crd-devel
branch
from
fd2b211
to
1f409fa
Compare
niladrih
approved these changes
Apr 9, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! 474: feat(upgrade-job): add helm value set for jaeger-operator update r=tiagolobocastro a=niladrih Requires PR 473  Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com> Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
Ensure helm dep var is set before we use it (cleanup). Rename it to capitals to make clear its global. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
473: fix(jaeger): update and use the jaeger bundled CRD r=tiagolobocastro a=tiagolobocastro It seems otherwise there's a race condition in which CRD gets installed depending on the helm version. We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator. Updates jaeger-operator. Note that as of now cert-manager is a required dependency for jaeger. <! Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems otherwise there's a race condition in which CRD gets installed depending on the helm version.
We don't actually need to use our own CRD for jaeger anymore, so let's instead if the bundled one from jaeger-operator.
Updates jaeger-operator.
Note that as of now cert-manager is a required dependency for jaeger.
Description
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: