Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix run on arm64 #7

Merged
merged 1 commit into from Aug 1, 2022
Merged

fix: fix run on arm64 #7

merged 1 commit into from Aug 1, 2022

Conversation

xin3liang
Copy link
Contributor

@xin3liang xin3liang commented Jul 6, 2022

Make nodeSelector configurable.

Make CSI sidecar images repo and tag configurable.
Use k8s offical repo as default, as it provides muti-arch images
for Arm64.

The verfied Arm64 override values are (run on microk8s):

cat >values-arm-override.yaml<<EOF
---
image:
  repo: xin3liang

nodeSelector:
  kubernetes.io/arch: arm64

csi:
  image:
    registry: docker.io
    repo: xin3liang
  node:
    kubeletDir: /var/snap/microk8s/common/var/lib/kubelet

mayastor:
  nodeSelector:
    kubernetes.io/arch: arm64

etcd:
  image:
    repository: xin3liang/bitnami-etcd
    tag: 3.5.1-debian-10-r67
  replicaCount: 1
  volumePermissions:
    image:
      repository: xin3liang/bitnami-shell

loki-stack:
  enabled: false
EOF

Signed-off-by: Xinliang Liu xinliang.liu@linaro.org

See verified result here:
https://linaro.atlassian.net/browse/STOR-104
close openebs/mayastor#1063

Make nodeSelector configurable.

Make CSI sidecar images repo and tag configurable.
Use k8s offical repo as default, as it provides muti-arch images
for Arm64.

The verfied Arm64 override values are:
image:
  repo: xin3liang
nodeSelector:
  kubernetes.io/arch: arm64
mayastor:
  nodeSelector:
    kubernetes.io/arch: arm64
etcd:
  image:
    repository: xin3liang/bitnami-etcd
    tag: 3.5.1-debian-10-r67
  replicaCount: 1
  volumePermissions:
    image:
      repository: xin3liang/bitnami-shell
loki-stack:
  enabled: false

Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
@xin3liang xin3liang mentioned this pull request Jul 6, 2022
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also adding the csi bits 👍

@xin3liang
Copy link
Contributor Author

ping

@tiagolobocastro
Copy link
Contributor

@vharsh could you please take a look as well? thanks

Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vharsh
Copy link
Member

vharsh commented Aug 1, 2022

bors try

bors bot pushed a commit that referenced this pull request Aug 1, 2022
@tiagolobocastro
Copy link
Contributor

Hmm bors seems stuck...
bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Aug 1, 2022

Build succeeded:

@bors bors bot merged commit d60676d into openebs:develop Aug 1, 2022
@bors
Copy link
Contributor

bors bot commented Aug 2, 2022

try

Timed out.

@mattmeye
Copy link

When is the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants