fix(nexus): assertion failure when unpublishing a faulted nexus #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
bors try |
tryBuild succeeded: |
chriswldenyer
approved these changes
Jan 6, 2021
mtzaurus
reviewed
Jan 6, 2021
gila
reviewed
Jan 6, 2021
mtzaurus
approved these changes
Jan 6, 2021
The assertion occurs due to the nvmf subsystem transitioning from a paused to an inactive state, which is forbidden. Always resume the nexus in child_retire so that it is usually in the active state, which avoids the assertion when unpublishing it. When there is only a single faulted child, the nexus itself is in a faulted state, which means no IO is possible. In nexus_bdev, fail the IO if all submissions failed, which also includes the case where no submissions were made. Refactor the post-IO submission to avoid repetition. Also include the case where no usable child was found when doing a round-robin for reads. This also fixes CAS-606. Repurpose the existing cargo test for a replica that is stopped, then continued, to test the cases above with a single remote replica.
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion occurs due to the nvmf subsystem transitioning from a
paused to an inactive state, which is forbidden. Always resume the
nexus in child_retire so that it is usually in the active state, which
avoids the assertion when unpublishing it.
Fixes #549, CAS-549, CAS-606.