Skip to content

Commit

Permalink
Renaming function and fixing comments.
Browse files Browse the repository at this point in the history
Signed-off-by: satbir <satbir.singh@mayadata.io>
  • Loading branch information
satbirchhikara committed Dec 7, 2018
1 parent f4323c7 commit 5c87687
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cmd/probe/seachestprobe.go
Expand Up @@ -66,11 +66,11 @@ var seachestProbeRegister = func() {
pi: &seachestProbe{Controller: ctrl},
controller: ctrl,
}
// Here we register the probe (smart probe in this case)
// Here we register the probe (seachest probe in this case)
newRegisterProbe.register()
}

// newSmartProbe returns smartProbe struct which helps populate diskInfo struct
// newSeachestProbe returns seachestProbe struct which helps populate diskInfo struct
// with the basic disk details such as logical size, firmware revision, etc
func newSeachestProbe(devPath string) *seachestProbe {
seachestIdentifier := &seachest.Identifier{
Expand Down Expand Up @@ -156,7 +156,7 @@ func (scp *seachestProbe) FillDiskDetails(d *controller.DiskInfo) {
}

if d.DriveType == "" {
d.DriveType = seachestProbe.SeachestIdentifier.IsRotational(driveInfo)
d.DriveType = seachestProbe.SeachestIdentifier.DriveType(driveInfo)
glog.Infof("Disk: %s DriveType:%s filled by seachest.", d.Path, d.DriveType)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/seachest/seachest.go
Expand Up @@ -158,7 +158,7 @@ func (I *Identifier) GetRotationRate(driveInfo *C.driveInformationSAS_SATA) uint
return 0
}

func (I *Identifier) IsRotational(driveInfo *C.driveInformationSAS_SATA) string {
func (I *Identifier) DriveType(driveInfo *C.driveInformationSAS_SATA) string {

if driveInfo.rotationRate == 0x0000 {
return "Not Available"
Expand Down

0 comments on commit 5c87687

Please sign in to comment.