Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmap support for jiva volume #2975

Closed
utkarshmani1997 opened this issue Mar 24, 2020 · 4 comments
Closed

Add unmap support for jiva volume #2975

utkarshmani1997 opened this issue Mar 24, 2020 · 4 comments

Comments

@utkarshmani1997
Copy link
Member

Description

When any data is written at the client side (iscsi) it is replicated to all the n no of jiva replicas. If the space is freed from the client side it is not freed at the replica side because jiva frontend (gotgt) doesn't support unmap.

Context

Since replicas consume some storage space unnecessarily, it should also do cleanup at the replica side.

Possible Solution

Jiva replicas implement unmap but it is not enabled from the [frontend] (https://github.com/gostor/gotgt) for remote backend. So implementation at frontend side is required to support this feature.

Also if this volume needs to be used for some other applications/databases, it is still usable and the data will be overwritten at the replica side and replica will reclaim the space.

Screenshots

@semekh
Copy link

semekh commented Apr 13, 2020

@utkarshmani1997 Is this issue related? longhorn/longhorn#836

@kmova
Copy link
Member

kmova commented Apr 13, 2020

It is @semekh

@github-actions
Copy link

Issues go stale after 90d of inactivity.

kmova added a commit to kmova/openebs that referenced this issue Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs/node-disk-manager#446
  - openebs/node-disk-manager#449
  - openebs/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs/node-disk-manager#448
  - openebs/maya#1632
  - openebs/jiva#279
  - openebs/maya#667
  - openebs/istgt#131
  - openebs/maya#561
  - openebs/maya#750
  ```

Signed-off-by: kmova <kiran.mova@mayadata.io>
kmova added a commit that referenced this issue Jul 15, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - #2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs/e2e-tests#405
  - #3038
  - #3023
  - #3037
  - #1295
  - openebs/linux-utils#5
  - openebs/node-disk-manager#446
  - openebs/node-disk-manager#449
  - openebs/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs/node-disk-manager#448
  - openebs/maya#1632
  - openebs/jiva#279
  - openebs/maya#667
  - openebs/istgt#131
  - openebs/maya#561
  - openebs/maya#750
  ```

Signed-off-by: kmova <kiran.mova@mayadata.io>
Jiva automation moved this from To do to Done Jul 20, 2020
Jiva automation moved this from Done to Under Development Jul 20, 2020
Jiva automation moved this from Under Development to Done Jul 28, 2020
Jiva automation moved this from Done to Under Development Sep 30, 2020
@payes payes moved this from Under Development to Near term goals in Jiva Oct 7, 2020
Akshay-Nagle pushed a commit to Akshay-Nagle/openebs that referenced this issue Oct 7, 2020
Refer: [GOVERNANCE.md](https://github.com/openebs/openebs/blob/master/GOVERNANCE.md).

The following community members have been helping with enhancing and testing
of several areas of the OpenEBS project that broadly fall in the purview of the
control plane.

Based on their past contributions and their interest/commitment to contributing
to OpenEBS, we take pride in adding them as reviewers to the OpenEBS project.

The list of community members in alphabetical order are:

- Mehran Kholdi for the contributions to the Local PV and control plane in general.
  ```
  - openebs#2975
  - 40+ commits in https://github.com/openebs/rawfile-localpv
  ```

- Michael Fornaro for the contributions to the ARM, Multi-arch builds and helm charts that fall under control plane.
  ```
  - openebs/e2e-tests#405
  - openebs#3038
  - openebs#3023
  - openebs#3037
  - openebs#1295
  - openebs/linux-utils#5
  - openebs/node-disk-manager#446
  - openebs/node-disk-manager#449
  - openebs/node-disk-manager#428
  ```

- Peeyush Gupta for the contributions to the Power builds and control plane in general.
  ```
  - openebs/charts#127
  - openebs/node-disk-manager#448
  - openebs/maya#1632
  - openebs/jiva#279
  - openebs/maya#667
  - openebs/istgt#131
  - openebs/maya#561
  - openebs/maya#750
  ```

Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: Kung Fu Panda <akshay_1901cb06@iitp.ac.in>
@github-actions
Copy link

Issues go stale after 90d of inactivity.

@github-actions github-actions bot closed this as completed Jan 6, 2021
Jiva automation moved this from Near term goals to Done Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Jiva
  
Done
Development

No branches or pull requests

4 participants