Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename maya/cmd/apiserver -> maya/cmd/maya-apiserver #630

Closed
kmova opened this issue Oct 14, 2017 · 6 comments
Closed

Rename maya/cmd/apiserver -> maya/cmd/maya-apiserver #630

kmova opened this issue Oct 14, 2017 · 6 comments
Labels
Milestone

Comments

@kmova
Copy link
Member

kmova commented Oct 14, 2017

It will be good if all the binaries at openebs/maya/cmd of openebs/maya will follow a standard convention.

Similar to kubernetes binaries, it will be good to have apiserver as maya-apiserver.

After renaming the binary name, the associated build scripts at this location also needs to be updated:

@kmova kmova added this to the 0.5 milestone Oct 14, 2017
@chentex
Copy link

chentex commented Oct 14, 2017

Do you need cmd folder apiserver renamed to maya-apiserver?

@SadPandaBear
Copy link

SadPandaBear commented Oct 14, 2017

Which tests can be runned to make sure everything is ok after renaming the folder?

@chentex
Copy link

chentex commented Oct 14, 2017

If you run make apiserver-image this will build an image to with the new command

@AmitKumarDas
Copy link
Member

@SadPandaBear Test with the new apiserver binary that gets generated via make apiserver-image or even make apiserver.
This binary can also be run as its CLI. Just run it & post the various options it displays.

@SadPandaBear
Copy link

SadPandaBear commented Oct 14, 2017

Should we rename the binary generated or just the folder + build script paths needed?

@prateekpandey14
Copy link
Member

PR is merged for this issue openebs-archive/maya#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants