oep(ndm): proposal for unique disk identification #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
gila
reviewed
Jul 8, 2019
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
reviewed
Sep 9, 2019
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
vishnuitta
reviewed
Sep 9, 2019
vishnuitta
reviewed
Sep 9, 2019
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
pawanpraka1
reviewed
Sep 16, 2019
pawanpraka1
reviewed
Sep 16, 2019
pawanpraka1
reviewed
Sep 16, 2019
footplus
reviewed
Sep 25, 2019
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
PRs go stale after 30d of inactivity. |
kmova
added this to Pre-commits and Designs - Due: Dec 31st 2019
in 1.7 Release Tracker - Due Feb 15th.
kmova
moved this from To do
to Pushed to Next release due to WIP
in 1.6 Release Tracker - Due Jan 15th.
kmova
moved this from Pre-commits and Designs - Due: Jan 31st 2020
to To do
in 1.7 Release Tracker - Due Feb 15th.
akhilerm
moved this from To do
to Pre-commits and Designs - Due: Jan 31st 2020
in 1.7 Release Tracker - Due Feb 15th.
akhilerm
moved this from Pre-commits and Designs - Due: Jan 31st 2020
to RC1 - Due: Feb 5 2020
in 1.7 Release Tracker - Due Feb 15th.
kmova
moved this from RC1 - Due: Feb 5 2020
to Pushed to Next release due to WIP
in 1.7 Release Tracker - Due Feb 15th.
kmova
reviewed
Feb 29, 2020
kmova
reviewed
Feb 29, 2020
7 tasks
kmova
pushed a commit
to openebs-archive/node-disk-manager
that referenced
this pull request
May 3, 2020
…386) This PR fixes the issue of disk unique identification in NDM. It implements the algorithm mentioned in [OEP#2666](openebs/openebs#2666). This will make NDM uniquely identify disks without an identifier in a cluster. Disk movement from one node to another, creating block device resources for partitions is also supported. This commit includes: - add support for partitions in NDM - implement the new UUID algorithm mentioned in [#2666](openebs/openebs#2666) - changes made on the a claimed BlockDevice (like creating partitions) are ignored. - if partitions are created on an unclaimed device, the device is marked inactive and resources will be created for the partitions. The following manual tests were done with on this commit: 1. disk with WWN - single BlockDevice resource is created 2. disk with WWN and 2 partitions - 2 Block Device resources are created for each partition 3. disks of type 1) and 2) are connected and disconnected while NDM is running 4. disks of type 1) and 2) are removed from one node and attached to another node 5. cstor claiming and creating pool on a disk with WWN and a partitioned disk 6. formatting the device with ext4 after claiming and NDM pod is restarted. Filesystem details are not updated on the resource Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
PRs go stale after 90d of inactivity. |
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
@kmova . Updated the OEP with latest details regarding implementation and upgrade of blockdevices. |
kmova
approved these changes
Sep 15, 2020
Akshay-Nagle
pushed a commit
to Akshay-Nagle/openebs
that referenced
this pull request
Oct 7, 2020
* added workflow chart * added WWN to flowchart * added partition also into the workflow * added 2 points in drawbacks section * Added new configuration options for UID generation * added QEMU_HARDDISK to list of models * updates OEP with latest changes and implementation details Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io> Signed-off-by: Kung Fu Panda <akshay_1901cb06@iitp.ac.in>
Akshay-Nagle
pushed a commit
to Akshay-Nagle/openebs
that referenced
this pull request
Oct 7, 2020
* added workflow chart * added WWN to flowchart * added partition also into the workflow * added 2 points in drawbacks section * Added new configuration options for UID generation * added QEMU_HARDDISK to list of models * updates OEP with latest changes and implementation details Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io> Signed-off-by: Kung Fu Panda <akshay_1901cb06@iitp.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement proposal for NDM. This proposal put forward a solution to uniquely identify a disk in a cluster.
Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io