refact(build): make the docker images configurable #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and Also trim leading v from image tag. Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added this to RC2 - Due May 10, 2020
in 1.10 Release Tracker - Due May 15th.
kmova
approved these changes
May 7, 2020
1.10 Release Tracker - Due May 15th.
automation
moved this from RC2 - Due May 10, 2020
to Done
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pawan pawan@mayadata.io
Why is this PR required? What issue does it fix?:
This PR makes the docker images configurable and removes the leading v from image tags. This is required to make the image name consistent with other openebs images
What this PR does?:
make the docker images configurable and trim leading v from image tag.
*Does this PR require any upgrade changes?**:
NA
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>