Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): adding v1 CRD for ZFS-LocalPV #140

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented May 31, 2020

fixes: #87

What this PR does?:

Moving the CRDs to stable v1 version.

Upgrade:

When an object is written, it is persisted at the version designated as the storage version at the time of the write. If the storage version changes, existing objects are never converted automatically. However, newly-created or updated objects are written at the new storage version. It is possible for an object to have been written at a version that is no longer served.

When you read an object, you specify the version as part of the path. If you specify a version that is different from the object’s persisted version, Kubernetes returns the object to you at the version you requested, but the persisted object is neither changed on disk, nor converted in any way (other than changing the apiVersion string) while serving the request. You can request an object at any version that is currently served.

If you update an existing object, it is rewritten at the version that is currently the storage version. This is the only way that objects can change from one version to another.

Here, made v1 as the storage version. And we can still query the v1alpha1 CRDs via v1 version. Since schema is same for both, using conversion strategy as none.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on

@pawanpraka1 pawanpraka1 added enhancement Add new functionality to existing feature pr/hold-review hold the review. labels May 31, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone May 31, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova May 31, 2020 15:47
Moving the CRDs to stable v1 version.

Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          14       14           
  Lines         489      489           
=======================================
  Hits          112      112           
  Misses        376      376           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ed7d8...76e2f9a. Read the comment docs.

@pawanpraka1 pawanpraka1 removed the pr/hold-review hold the review. label Jun 1, 2020
@pawanpraka1 pawanpraka1 added this to In progress in ZFS Local PV Jun 1, 2020
@pawanpraka1 pawanpraka1 added this to RC1 - Due: Jun 5 2020 in 1.11 Release Tracker - Due June 15th. Jun 1, 2020
@kmova kmova changed the title feat(beta): adding v1 CRD for ZFS-LocalPV feat(spec): adding v1 CRD for ZFS-LocalPV Jun 4, 2020
@kmova kmova merged commit 1e23607 into openebs:master Jun 4, 2020
ZFS Local PV automation moved this from In progress to Done Jun 4, 2020
1.11 Release Tracker - Due June 15th. automation moved this from RC1 - Due: Jun 5 2020 to Done Jun 4, 2020
@pawanpraka1 pawanpraka1 deleted the beta branch June 8, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

moving ZFSPV API version to v1
4 participants