Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): migrate to go modules and bump go version 1.14.4 #148

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

prateekpandey14
Copy link
Member

@prateekpandey14 prateekpandey14 commented Jun 5, 2020

Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io

Pull Request template

Why is this PR required? What issue does it fix?:

This PR enables the zfs localpv to be built using Go Modules

Changes Made include

  • changes in the Makefile to add go mod tidy, verify & vendor commands and GO111MODULE=on
  • changes in travis.yml & travis.sh to enable its building from gomodules
  • adds vendor folder
  • removes Gopkg lock & toml
  • bump travis go version to 1.14.4 for better go module support

Steps Performed

  • Go mod init
  • Go mod tidy
  • Added go mod tidy and god mod verify in the Makefile
  • Removed gopkg.toml and gopkg.lock
  • Other fixes mentioned above
  • go mod vendor

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #148 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   22.90%   22.65%   -0.26%     
==========================================
  Files          14       14              
  Lines         489      490       +1     
==========================================
- Hits          112      111       -1     
- Misses        376      378       +2     
  Partials        1        1              
Impacted Files Coverage Δ
pkg/usage/ping.go 40.00% <0.00%> (-3.75%) ⬇️
pkg/usage/usage.go 0.00% <0.00%> (ø)
pkg/usage/versionset.go 0.00% <0.00%> (ø)
pkg/usage/googleanalytics.go 0.00% <0.00%> (ø)
pkg/client/k8s/v1alpha1/namespace.go 0.00% <0.00%> (ø)
pkg/common/kubernetes/client/client.go 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e22239...f027420. Read the comment docs.

Makefile Show resolved Hide resolved
@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jun 9, 2020
@pawanpraka1 pawanpraka1 added this to the v0.8.0 milestone Jun 9, 2020
@pawanpraka1 pawanpraka1 added this to In progress in ZFS Local PV Jun 9, 2020
@pawanpraka1 pawanpraka1 moved this from In progress to In Review in ZFS Local PV Jun 9, 2020
@pawanpraka1 pawanpraka1 added this to RC1 - Due: Jun 5 2020 in 1.11 Release Tracker - Due June 15th. Jun 9, 2020
.travis.yml Outdated Show resolved Hide resolved
@pawanpraka1 pawanpraka1 changed the title test go module feat(mod): adding go module for ZFS-LocalPV Jun 9, 2020
@prateekpandey14 prateekpandey14 changed the title feat(mod): adding go module for ZFS-LocalPV feat(modules): migrate to go modules and bump go version 1.14.4 Jun 9, 2020
- migrate to go module
- bump go version 1.14.4

Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@pawanpraka1 pawanpraka1 merged commit fa76b34 into openebs:master Jun 9, 2020
ZFS Local PV automation moved this from In Review to Done Jun 9, 2020
1.11 Release Tracker - Due June 15th. automation moved this from RC1 - Due: Jun 5 2020 to Done Jun 9, 2020
@prateekpandey14 prateekpandey14 deleted the go-mod branch June 9, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants