Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zfspv): mounting the volume if it is ready #184

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

pawanpraka1
Copy link
Contributor

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

Instead of checking for the finalizer, checking for the
volume state to be ready is more intuitive before mounting it.

Also removed duplicate if statement for btrfs which was added while resolveing
the merge conflict in #175.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label Jul 21, 2020
@pawanpraka1 pawanpraka1 added this to the v0.10 milestone Jul 21, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova July 21, 2020 06:27
@pawanpraka1 pawanpraka1 added this to In progress in ZFS Local PV Jul 21, 2020
@pawanpraka1 pawanpraka1 added this to Pre-commits and Designs - Due: Jul 31 2020 in 2.0 Release Tracker - Due Aug 15th. Jul 21, 2020
Instead of checking for the finalizer, checking for the
volume state to be ready is more intuitive before mounting it.

Also removed duplicate if statement for btrfs which was added while resolveing
the merge conflict in openebs#175.

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   22.88%   22.88%           
=======================================
  Files          14       14           
  Lines         485      485           
=======================================
  Hits          111      111           
  Misses        373      373           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b4f0b...e41498c. Read the comment docs.

@kmova kmova merged commit e00a6b9 into openebs:master Jul 22, 2020
ZFS Local PV automation moved this from In progress to Done Jul 22, 2020
2.0 Release Tracker - Due Aug 15th. automation moved this from Pre-commits and Designs - Due: Jul 31 2020 to Done Jul 22, 2020
@pawanpraka1 pawanpraka1 deleted the status branch July 27, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants