Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zfspv): rounding off the volume size to Gi and Mi #191

Merged
merged 2 commits into from
Aug 7, 2020
Merged

fix(zfspv): rounding off the volume size to Gi and Mi #191

merged 2 commits into from
Aug 7, 2020

Commits on Aug 7, 2020

  1. fix(zfspv): rounding off the volume size to Gi and Mi 

    ZFS does not create the zvol if volume size is not multiple of
the volblocksize. There are use cases where customer will create
a PVC with size as 5G, which will be 5 * 1000 * 1000 * 1000 bytes
and this is not the multiple of default volblocksize 8k.

In ZFS, volblocksize and recordsize must be power of 2 from 512B to 1M,
so keeping the size in the form of Gi or Mi should be
sufficient to make volsize multiple of volblocksize/recordsize.

Signed-off-by: Pawan <pawan@mayadata.io>
    @pawanpraka1
    pawanpraka1 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    c6222a6 View commit details
    Browse the repository at this point in the history

  2. fix(zfspv): adding GB and MB unit test cases 

    Signed-off-by: Pawan <pawan@mayadata.io>
    @pawanpraka1
    pawanpraka1 committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    bc5b2cd View commit details
    Browse the repository at this point in the history