Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): adding CSI Sanity test #232

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Nov 2, 2020

Signed-off-by: Pawan pawan@mayadata.io

What this PR does?:

adding CSI sanity test for ZFS-LocalPV

Changes?:

  1. convert volume name and snapshot name to lowercase as they are needed to create a CR and uppercase characters are not allowed
  2. returning proper error code in the code
  3. added "wait" functionality to wait for volume/operation creation, needed since sanity does not have retry logic
  4. add functionality to pass "node" where PV should be created, needed since sanity does not pass topology information
  5. added few checks to return correct error codes

@pawanpraka1 pawanpraka1 added the pr/hold-review hold the review. label Nov 2, 2020
@pawanpraka1 pawanpraka1 added this to the v1.1.0 milestone Nov 2, 2020
@pawanpraka1 pawanpraka1 added this to In Review in ZFS Local PV Nov 2, 2020
@pawanpraka1 pawanpraka1 moved this from In Review to In progress in ZFS Local PV Nov 2, 2020
@pawanpraka1 pawanpraka1 added this to RC1 - Due: Nov 5 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 2, 2020
@pawanpraka1 pawanpraka1 moved this from RC1 - Due: Nov 5 2020 to Pre-commits and Designs - Due: Oct 31 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 2, 2020
@prateekpandey14 prateekpandey14 moved this from Pre-commits and Designs - Due: Oct 31 2020 to RC1 - Due: Nov 5 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 4, 2020
Makefile Outdated

.PHONY: sanity
sanity:
@echo "--> Running ci test";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_: running csi-sanity tests

ci/ci-test.sh Outdated
@@ -89,7 +89,7 @@ set +e

echo "running ginkgo test case"

ginkgo -v
# ginkgo -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_ remove it.

@prateekpandey14 prateekpandey14 moved this from RC1 - Due: Nov 5 2020 to RC2 - Due: Nov 10 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 6, 2020
@pawanpraka1 pawanpraka1 added this to the v1.2.0 milestone Nov 23, 2020
@pawanpraka1 pawanpraka1 added this to Pre-commits and Designs - Due: Nov 30 2020 in 2.4 Release Tracker - Due Dec 15th. Nov 24, 2020
@pawanpraka1 pawanpraka1 removed the pr/hold-review hold the review. label Nov 24, 2020
@pawanpraka1 pawanpraka1 added the pr/hold-merge hold the merge. label Nov 25, 2020
@akhilerm akhilerm moved this from Pre-commits and Designs - Due: Nov 30 2020 to RC1 - Due: Dec 5 2020 in 2.4 Release Tracker - Due Dec 15th. Dec 3, 2020
@pawanpraka1 pawanpraka1 removed the pr/hold-merge hold the merge. label Dec 4, 2020
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
@kmova kmova merged commit a73a59f into openebs:master Dec 10, 2020
ZFS Local PV automation moved this from In progress to Done Dec 10, 2020
2.3 Release Tracker - Due Nov 15th. automation moved this from Pushed to Next release due to WIP to Done Dec 10, 2020
2.4 Release Tracker - Due Dec 15th. automation moved this from RC1 - Due: Dec 5 2020 to Done Dec 10, 2020
@pawanpraka1 pawanpraka1 deleted the sanity branch December 10, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants