Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yaml): changing the zfs-driver images to multi-arch docker hub images #237

Merged
merged 4 commits into from
Nov 14, 2020
Merged

chore(yaml): changing the zfs-driver images to multi-arch docker hub images #237

merged 4 commits into from
Nov 14, 2020

Conversation

w3aman
Copy link
Contributor

@w3aman w3aman commented Nov 12, 2020

Signed-off-by: Aman Gupta aman.gupta@mayadata.io

  • This PR changes the zfs-driver quay images to docker hub image.
    quay.io/openebs/zfs-driver:ci ===> openebs/zfs-driver:ci

Signed-off-by: Aman Gupta <aman.gupta@mayadata.io>
@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #237 (1064765) into master (fb6f100) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #237   +/-   ##
======================================
  Coverage    8.27%   8.27%           
======================================
  Files          20      20           
  Lines        1076    1076           
======================================
  Hits           89      89           
  Misses        986     986           
  Partials        1       1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6f100...a4c6012. Read the comment docs.

@@ -581,7 +581,7 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: openebs-zfs-plugin
image: quay.io/openebs/zfs-driver:ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us make it zfs-driver-amd64 every where.

Signed-off-by: Aman Gupta <aman.gupta@mayadata.io>
@pawanpraka1 pawanpraka1 added this to the v1.1.0 milestone Nov 13, 2020
@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Nov 13, 2020
@pawanpraka1 pawanpraka1 added this to In progress in ZFS Local PV Nov 13, 2020
@pawanpraka1 pawanpraka1 added this to RC1 - Due: Nov 5 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 13, 2020
@pawanpraka1 pawanpraka1 moved this from RC1 - Due: Nov 5 2020 to RC2 - Due: Nov 10 2020 in 2.3 Release Tracker - Due Nov 15th. Nov 13, 2020
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@w3aman w3aman changed the title chore(yaml): changing the zfs-driver quay images to docker-hub images chore(yaml): changing the zfs-driver images to multi-arch docker hub images Nov 13, 2020
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kmova kmova merged commit 919a058 into openebs:master Nov 14, 2020
ZFS Local PV automation moved this from In progress to Done Nov 14, 2020
2.3 Release Tracker - Due Nov 15th. automation moved this from RC2 - Due: Nov 10 2020 to Done Nov 14, 2020
kmova pushed a commit that referenced this pull request Nov 14, 2020
…images (#237)



Signed-off-by: Aman Gupta <aman.gupta@mayadata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants