Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add github action for chart test and release #250

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

shubham14bajpai
Copy link
Member

@shubham14bajpai shubham14bajpai commented Dec 7, 2020

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:

This PR adds github action CI for zfs-localpv helm chart lint, test and release.

Note: The zfs-localpv helm charts will reside in a directory structure: deploy/helm

The following are the details of changes :

  1. Adds Chart Lint and Test action to test and lint the chart changes.
  • This action is only triggered if there is any change in the content of deploy/helm directory.
  1. Modifies the existing Go action.
  • As a result of the modification, the action will not run for pull requests if there are changes in the deploy/helm directory.
  1. Adds a Release Charts action to release the helm chart.
  • This action triggers only when the push in against master and there is a change in the content of deploy/helm directory.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@codecov-io
Copy link

codecov-io commented Dec 7, 2020

Codecov Report

Merging #250 (f3dc159) into master (e1e8aa5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #250   +/-   ##
======================================
  Coverage    8.50%   8.50%           
======================================
  Files          20      20           
  Lines        1047    1047           
======================================
  Hits           89      89           
  Misses        957     957           
  Partials        1       1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e8aa5...1331cb0. Read the comment docs.

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham14bajpai The branch name needs to be changed from develop to master.

Co-authored-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@shubham14bajpai shubham14bajpai added this to RC1 - Due: Dec 5 2020 in 2.4 Release Tracker - Due Dec 15th. Dec 8, 2020
@akhilerm akhilerm moved this from RC1 - Due: Dec 5 2020 to RC2 - Due: Dec 10 2020 in 2.4 Release Tracker - Due Dec 15th. Dec 8, 2020
@akhilerm akhilerm self-requested a review December 9, 2020 06:41
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @shubham14bajpai ct.yaml needs to be added , check the PR dynamic-localpv for the reference.

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@pawanpraka1 pawanpraka1 merged commit 0c8202b into openebs:master Dec 11, 2020
2.4 Release Tracker - Due Dec 15th. automation moved this from RC2 - Due: Dec 10 2020 to Done Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants