Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): update k8s sidecar images to gcr #284

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

shubham14bajpai
Copy link
Member

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:
This PR updates the k8s csi sidecars to gcr for better multi-arch support.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump the chart version as well in Chart.yaml , also we can think of including the charts changes in upcoming release as well cc @pawanpraka1

@shubham14bajpai shubham14bajpai changed the title chore(deploy): update k8s sidecar images to gcr chore(operator): update k8s sidecar images to gcr Feb 4, 2021
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@codecov-io
Copy link

Codecov Report

Merging #284 (cc11b27) into master (88ad25e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #284   +/-   ##
======================================
  Coverage    1.08%   1.08%           
======================================
  Files          11      11           
  Lines         918     918           
======================================
  Hits           10      10           
  Misses        908     908           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ad25e...cc11b27. Read the comment docs.

Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawanpraka1 pawanpraka1 merged commit 36e0f69 into openebs:master Feb 5, 2021
ZFS Local PV automation moved this from In Review to Done Feb 5, 2021
2.6 Release Tracker - Due Feb 15th. automation moved this from RC1 - Due: Feb 5 2020 to Done Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants