-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(operator): update k8s sidecar images to gcr #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump the chart version as well in Chart.yaml
, also we can think of including the charts changes in upcoming release as well cc @pawanpraka1
163cbaf
to
7e0d1a9
Compare
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
======================================
Coverage 1.08% 1.08%
======================================
Files 11 11
Lines 918 918
======================================
Hits 10 10
Misses 908 908 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does?:
This PR updates the k8s csi sidecars to gcr for better multi-arch support.
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>