feat(scheduling): add zfs pool capacity tracking #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
shubham14bajpai
added this to Pre-commits and Designs - Due: May 31 2021
in 2.10 Release Tracker - Due June 15th.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
akhilerm
reviewed
May 21, 2021
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
pawanpraka1
reviewed
May 31, 2021
pkg/mgmt/zfsnode/zfsnode.go
Outdated
| // Finally, if no error occurs we Forget this item so it does not | ||
| // get queued again until another change happens. | ||
| c.workqueue.Forget(obj) | ||
| klog.Infof("Successfully synced '%s'", key) |
There was a problem hiding this comment.
let us remove this (or put it under more verbose) as it will pollute the log every minute.
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
2.10 Release Tracker - Due June 15th.
automation
moved this from Pre-commits and Designs - Due: May 31 2021
to Done
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
Why is this PR required? What issue does it fix?:
This PR
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>