fix(zfspv): do not destroy the dataset with -R option #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With "zfs destroy -R" we will delete snapshot and clones also. We should not use that for deleting the volumes. Signed-off-by: Pawan <pawan@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 1 1
Lines 72 72
=======================================
Hits 60 60
Misses 12 12Continue to review full report at Codecov.
|
kmova
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With "zfs destroy -R" we will delete snapshot and clones also. We should
not use that for deleting the volumes.
Signed-off-by: Pawan pawan@mayadata.io